Record and log additional metrics for O #1670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Record and log the following metrics on O:
B downloads the transcoded results from O separately and the associated HTTP handler lives in LPMS so I did not try to add metrics instrumentation there for now. As a result, this PR does not include the ability to measure the ratio between source segment duration and round trip time from O's POV.
A few other minor updates:
monitor
package. I felt that this would be less prone to error when writing conditionals based on the current node type as is done in 7a05697 which skips extra state tracking code inSegmentEmerged
if the function is used for a node type other than a broadcasterSpecific updates (required)
See commit history.
How did you test each of these updates (required)
Tested manually and observed metrics using livepeer/docker-livepeer#44.
Does this pull request close any open issues?
Fixes #1661
Checklist:
./test.sh
pass